Adds a TOC to the maintainer checklist #15376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and makes some minor adjustments to wordings to clarify actions to be taken when.
colindean
commented
May 7, 2023
MikeMcQuaid
reviewed
May 8, 2023
My intent was to disambiguate what ownership means and be specific but we decided it was better to just keep the title the same since that's what it's called in all of the systems.
p-linnane
approved these changes
May 9, 2023
colindean
commented
May 10, 2023
MikeMcQuaid
approved these changes
May 10, 2023
There was a problem hiding this comment.
Looks good, thanks @colindean! Assuming remaining owners references were typos so gonna apply my own suggestions and enable auto-merge.
|
Yes, I'm okay with that. Thanks for the cleanup. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and makes some minor adjustments to wordings to clarify actions to be taken when.
Have you written new tests for your changes? Here's an example.Have you successfully runbrew stylewith your changes locally?Have you successfully runbrew typecheckwith your changes locally?Have you successfully runbrew testswith your changes locally?